Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade phpcodesniffer-composer-installer #36791

Closed
wants to merge 14 commits into from
Closed

Upgrade phpcodesniffer-composer-installer #36791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7e80263
Upgrade phpcodesniffer-composer-installer
fredden Jan 30, 2023
555a57d
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Mar 3, 2023
2770a59
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Mar 14, 2023
6afc2fa
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Apr 4, 2023
aceddf6
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Jul 17, 2023
45a3ca4
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Aug 18, 2023
22ce531
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Sep 5, 2023
60c5edc
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Sep 8, 2023
0ddf6b7
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Sep 25, 2023
740a73c
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Dec 27, 2023
6537888
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Jan 19, 2024
397b196
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Feb 6, 2024
708d0f2
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Feb 13, 2024
2ef3c63
Merge remote-tracking branch 'upstream/2.4-develop' into phpcs-installer
fredden Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
},
"require-dev": {
"allure-framework/allure-phpunit": "^2",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7 || ^1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As same as for codding-standard repo PR I believe that "^1.0" will be enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing here that's not compatible with ^0.7.0. I've specifically kept this because I expect other packages may take a while to upgrade / allow the new version. If there's something that requires ^0.7, it'll work today, but not after merging if we change this to ^1.0 only. Listing both supported versions means that interoperability with other packages is maintained; Composer will pick the "best" version, which is typically the highest mutually-supported version. If we use ^1.0 only here, then we're forcing others to upgrade their packages in order for their coding standard to be used in conjunction with this product.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

"dg/bypass-finals": "^1.4",
"friendsofphp/php-cs-fixer": "^3.22",
"lusitanian/oauth": "^0.8",
Expand Down
2 changes: 1 addition & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.