Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStorm Remote Call is broken #72

Closed
jissereitsma opened this issue Jan 23, 2024 · 6 comments
Closed

PHPStorm Remote Call is broken #72

jissereitsma opened this issue Jan 23, 2024 · 6 comments

Comments

@jissereitsma
Copy link
Contributor

The original IntteliJ IDE plugin Remote Call (https://plugins.jetbrains.com/plugin/6027-remote-call) seems no longer maintained and is no longer compatible with current PHPStorm versions.

Instead, JetBrain offers another plugin called IDE Remote Control (https://plugins.jetbrains.com/plugin/19991-ide-remote-control).

To migrate, the docs need to be changed, the default port 8091 needs to be changed to 63342 and the structure of the URL needs to change itself as well: From /?message={file}:{line} to /api/file/{file}:{line}. I haven't found in https://github.com/magespecialist/mage-chrome-toolbar where this should be referenced though (yet)

@gerarddevisser
Copy link

gerarddevisser commented Jan 23, 2024

@jissereitsma

Also encountered this issue and using a local workaround for now:
Set system config setting msp_devtools/phpstorm/port to 63342 and use this patch with IDE Remote Control enabled in PhpStorm:

diff --git a/vendor/msp/devtools/Model/Config.php b/vendor/msp/devtools/Model/Config.php
index 5bd04f8..065fdbd 100644
--- a/vendor/msp/devtools/Model/Config.php
+++ b/vendor/msp/devtools/Model/Config.php
@@ -112,7 +112,7 @@ class Config
             return null;
         }

-        return 'http://127.0.0.1:' . $this->getPhpStormPort() . '?message=' . urlencode($file);
+        return 'http://127.0.0.1:' . $this->getPhpStormPort() . '/api/file?file=' . urlencode(ltrim($file, '/'));
     }

     /**

If you think it's the right fix, I can create a pull request with this change.

@jissereitsma
Copy link
Contributor Author

Yes, this is it! Thanks so much for already providing the solution. I had only had a quick look and in the wrong place. Indeed, if you could make this a Pull Request, then we can sing some Italian songs to merge it!

@jissereitsma
Copy link
Contributor Author

How cool! It is working again. If you could add a PR for this, it would be great. Also, could you include the port change in the PR as well? This would be in 2 places: In the Model/Config.php file on line 98, changing 8091 to 63342. And in etc/config.xml as well on line 32.

@gerarddevisser
Copy link

@jissereitsma PR is created: #73
Can you do the Italian song? 😉

@jissereitsma
Copy link
Contributor Author

jissereitsma commented Jan 30, 2024

https://vimeo.com/317091318

@mikimpe
Copy link
Contributor

mikimpe commented Apr 22, 2024

Fixed in latest release 1.2.18

@mikimpe mikimpe closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants