From d122749348d196b8626225d8741e6cdcb6e714bd Mon Sep 17 00:00:00 2001
From: Ethan Rogers <ethanfrogers@users.noreply.github.com>
Date: Tue, 7 May 2019 10:38:34 -0400
Subject: [PATCH] feat(runJob/kubernetes): render external link (#6930)

if `context.execution.logs` is present (pulled from manifest annotation
`jobs.spinnaker.io/logs`), render the content as a link, templated with
manifest data.
---
 .../manifest/stage/JobStageExecutionLogs.tsx  | 28 +++++++++++++++++--
 .../PreconfiguredJobExecutionDetails.tsx      |  2 ++
 .../stages/runJob/RunJobExecutionDetails.tsx  |  2 ++
 3 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/app/scripts/modules/core/src/manifest/stage/JobStageExecutionLogs.tsx b/app/scripts/modules/core/src/manifest/stage/JobStageExecutionLogs.tsx
index cf4dd69100e..2b2560ea19b 100644
--- a/app/scripts/modules/core/src/manifest/stage/JobStageExecutionLogs.tsx
+++ b/app/scripts/modules/core/src/manifest/stage/JobStageExecutionLogs.tsx
@@ -5,7 +5,7 @@ import { IStageManifest, ManifestService } from '../ManifestService';
 import { JobManifestPodLogs } from './JobManifestPodLogs';
 import { IManifest } from 'core/domain/IManifest';
 
-import { get } from 'lodash';
+import { get, template, isEmpty } from 'lodash';
 import { Application } from 'core/application';
 
 interface IJobStageExecutionLogsProps {
@@ -13,6 +13,7 @@ interface IJobStageExecutionLogsProps {
   deployedName: string;
   account: string;
   application: Application;
+  externalLink: string;
 }
 
 interface IJobStageExecutionLogsState {
@@ -30,7 +31,7 @@ export class JobStageExecutionLogs extends React.Component<IJobStageExecutionLog
     this.componentDidUpdate(this.props, this.state);
   }
 
-  public componentWillMount() {
+  public componentWillUnmount() {
     this.unsubscribe();
   }
 
@@ -84,13 +85,34 @@ export class JobStageExecutionLogs extends React.Component<IJobStageExecutionLog
     };
   }
 
+  private renderExternalLink(link: string, manifest: IManifest): string {
+    if (!link.includes('{{')) {
+      return link;
+    }
+    // use {{ }} syntax to align with the annotation driven UI which this
+    // derives from
+    return template(link, { interpolate: /{{([\s\S]+?)}}/g })({ ...manifest });
+  }
+
   public render() {
     const { manifest } = this.state.subscription;
+    const { externalLink } = this.props;
+
+    // prefer links to external logging platforms
+    if (!isEmpty(manifest) && externalLink) {
+      return (
+        <a target="_blank" href={this.renderExternalLink(externalLink, manifest)}>
+          Console Output (External)
+        </a>
+      );
+    }
+
     let event: any = null;
     if (manifest && manifest.events) {
       event = manifest.events.find((e: any) => e.message.startsWith('Created pod'));
     }
-    if (!manifest || !event) {
+
+    if (isEmpty(manifest) && isEmpty(event)) {
       return <div>No Console Output</div>;
     }
 
diff --git a/app/scripts/modules/core/src/pipeline/config/stages/preconfiguredJob/PreconfiguredJobExecutionDetails.tsx b/app/scripts/modules/core/src/pipeline/config/stages/preconfiguredJob/PreconfiguredJobExecutionDetails.tsx
index bd2689767b3..4059f39ee06 100644
--- a/app/scripts/modules/core/src/pipeline/config/stages/preconfiguredJob/PreconfiguredJobExecutionDetails.tsx
+++ b/app/scripts/modules/core/src/pipeline/config/stages/preconfiguredJob/PreconfiguredJobExecutionDetails.tsx
@@ -21,6 +21,7 @@ export class PreconfiguredJobExecutionDetails extends React.Component<IExecution
       const namespace = get(manifest, ['metadata', 'namespace']);
       const deployedJobs = get(this.props.stage, ['context', 'deploy.jobs']);
       const deployedName = get(deployedJobs, namespace, [])[0] || '';
+      const externalLink = get<string>(this.props.stage, ['context', 'execution', 'logs']);
       return (
         <div className="well">
           <JobStageExecutionLogs
@@ -28,6 +29,7 @@ export class PreconfiguredJobExecutionDetails extends React.Component<IExecution
             deployedName={deployedName}
             account={this.props.stage.context.account}
             application={this.props.application}
+            externalLink={externalLink}
           />
         </div>
       );
diff --git a/app/scripts/modules/kubernetes/src/v2/pipelines/stages/runJob/RunJobExecutionDetails.tsx b/app/scripts/modules/kubernetes/src/v2/pipelines/stages/runJob/RunJobExecutionDetails.tsx
index 4ddade274cd..b3cb8a815cd 100644
--- a/app/scripts/modules/kubernetes/src/v2/pipelines/stages/runJob/RunJobExecutionDetails.tsx
+++ b/app/scripts/modules/kubernetes/src/v2/pipelines/stages/runJob/RunJobExecutionDetails.tsx
@@ -28,6 +28,7 @@ export class RunJobExecutionDetails extends React.Component<IExecutionDetailsSec
 
     const { manifest } = context;
     const deployedName = this.extractDeployedJobName(manifest, get(context, ['deploy.jobs']));
+    const externalLink = get<string>(stage, ['context', 'execution', 'logs']);
 
     return (
       <ExecutionDetailsSection name={name} current={current}>
@@ -51,6 +52,7 @@ export class RunJobExecutionDetails extends React.Component<IExecutionDetailsSec
                   deployedName={deployedName}
                   account={this.props.stage.context.account}
                   application={this.props.application}
+                  externalLink={externalLink}
                 />
               </dd>
             </dl>