Replies: 3 comments
-
That seems worth supporting. Give this a try: diff --git a/lisp/magit-section.el b/lisp/magit-section.el
index 3432fa4a32..0e27357e78 100644
--- a/lisp/magit-section.el
+++ b/lisp/magit-section.el
@@ -2396,6 +2396,7 @@ (defun magit--make-bookmark ()
bookmark)
(user-error "Bookmarking is not implemented for %s buffers" major-mode)))
+;;;###autoload
(defun magit--handle-bookmark (bookmark)
"Open a bookmark created by `magit--make-bookmark'.
@@ -2405,6 +2406,7 @@ (defun magit--handle-bookmark (bookmark)
Then call the `magit-*-setup-buffer' function of the the major-mode
with the variables' values as arguments, which were recorded by
`magit--make-bookmark'."
+ (require 'magit-bookmark nil t)
(let ((buffer (magit-bookmark-get-buffer-create
bookmark
(bookmark-prop-get bookmark 'mode)))) and if it works, open a pull-request, with a message that explains why we are doing this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Thanks, that works perfectly (once I ran |
Beta Was this translation helpful? Give feedback.
0 replies
-
See PR #5169. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm using activities by @alphapapa, which uses bookmarks to restore buffers and windows. I tend to accumulate magit buffers among my activity's windows and have always wished magit could restore them. To my surprise I discovered
magit--handle-bookmark
already exists!Magit buffer/window recovery does not currently function with activities after a start, however, since
magit--handle-bookmark
isn't loaded. I think anautoload
to loadmagit-section
would fix this. Probably thecl-defmethod
's inmagit-bookmark
also need to be loaded.Beta Was this translation helpful? Give feedback.
All reactions