Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (sn_cli): Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs #1892

Closed
wants to merge 1 commit into from
Closed

fix (sn_cli): Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs #1892

wants to merge 1 commit into from

Conversation

willief
Copy link
Contributor

@willief willief commented Jun 14, 2024

fix: Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs

Description

Existing error message referred to "files upload"
This changes the error to refer to "files download"

Related Issue

Fixes #1890

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@willief
Update files.rs
a3d3382 
Existing error message referred to "files upload"
This changes the error to refer to "files download"
@willief willief changed the title fix: Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs fix (sn_cli): Correct a misleading error msg in sn_cli/src/bin/subcommands/files.rs Jun 14, 2024
@joshuef joshuef mentioned this pull request Jun 15, 2024
Merged
@joshuef
Copy link
Contributor

joshuef commented Jun 15, 2024

Thanks for this @willief . For simplicity i've made #1893 which adds the title you have (almost perfect commit convention) to the commit msg.

That should now pass the CI checks therein

(note the lack of sentence case and no space before subject, ie fix(cli) not fix (cli))

@joshuef joshuef closed this Jun 15, 2024
@willief
Copy link
Contributor Author

willief commented Jun 16, 2024 via email

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuef joshuef joshuef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: (sn_cli): Files download error msg is misleading
2 participants
@willief @joshuef