Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored arguments to Values interface #11

Merged
merged 10 commits into from
Jun 29, 2021
Merged

Refactored arguments to Values interface #11

merged 10 commits into from
Jun 29, 2021

Conversation

mailund
Copy link
Owner

@mailund mailund commented Jun 29, 2021

This interface is cleaner, I can autogenerate code for various types (and now support all basic types and slices of same), and I support more types of callbacks plus any type that implements the right interface.

Closes #10 #9 #6 #5 and #4

@mailund mailund merged commit 1cba3e1 into main Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #11 (4ca256b) into main (2f3c600) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main       #11    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            5         7     +2     
  Lines          310       509   +199     
==========================================
+ Hits           310       509   +199     
Impacted Files Coverage Δ
commands.go 100.00% <100.00%> (ø)
internal/params/paramset.go 100.00% <100.00%> (ø)
internal/vals/callbacks.go 100.00% <100.00%> (ø)
internal/vals/genvals.go 100.00% <100.00%> (ø)
internal/vals/vals.go 100.00% <100.00%> (ø)
specs.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3c600...4ca256b. Read the comment docs.

@mailund mailund deleted the values branch June 29, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify and refactor paramset
1 participant