Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate authorize method #1994

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Deprecate authorize method #1994

merged 5 commits into from
Oct 31, 2019

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Oct 30, 2019

This deprecates the DataAdapterMixin's authorize method in favor of setting the headers property on the adapter.

@marcoow marcoow marked this pull request as ready for review October 30, 2019 16:46
marcoow and others added 2 commits October 30, 2019 19:47
@marcoow @sdebarros
Update addon/mixins/data-adapter-mixin.js
3dd4fae 
Co-Authored-By: Samanta de Barros <samanta.dbarros@gmail.com>
@marcoow
fix docs
3a0c303
@marcoow marcoow merged commit d524c8a into master Oct 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the deprecate-authorize-method branch October 31, 2019 12:44
@sbedeau sbedeau mentioned this pull request Jan 31, 2020
Merged
sbedeau pushed a commit to 1024pix/pix that referenced this pull request Feb 4, 2020
@jonasgrilleres @sbedeau
Adopt ember-simple-auth auth recommendations
db1a357 
Authentication header are now passed as query-params instead of xhr
as suggested in the following documentations
-> mainmatter/ember-simple-auth#1994

It also affects the load of the current user as suggested here:
-> https://github.com/simplabs/ember-simple-auth/blob/master/guides/managing-current-user.md#loading-the-current-user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdebarros sdebarros sdebarros approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoow @sdebarros