Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize tests #2013

Merged
merged 8 commits into from
Nov 22, 2019
Merged

Modernize tests #2013

merged 8 commits into from
Nov 22, 2019
+810 −657

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Nov 11, 2019 •
edited
Loading

This modernizes the test suite by:

  • using the latest ember-mocha (vs. not using ember-mocha at all)
  • using ember-mocha's setupXYZ helpers
  • removing the manually-mocked container (and replacing it with the owner set up by ember-mocha's setupXYZ helpers)
  • using async/await in tests
  • removing the createWithContainer helper

@marcoow marcoow marked this pull request as ready for review November 12, 2019 08:28
@marcoow marcoow force-pushed the modernize-tests branch 3 times, most recently from fbb75bc to 6edc506 Compare November 12, 2019 09:22
@marcoow marcoow force-pushed the modernize-tests branch 3 times, most recently from 4deec87 to cace2a9 Compare November 13, 2019 16:53
@marcoow marcoow merged commit db8f9cf into master Nov 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the modernize-tests branch November 22, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdebarros sdebarros sdebarros approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoow @sdebarros