Fixed failing unit test - invalidate call revoke endpoint twice. Unit test did not validate it correctly. #2349
Conversation
|
Isn't this working correctly on |
|
It is failing on master also. Revoke endpoint is called twice and it fails on the first request and succeeds on the second. It is not caught by mocha, because it is not correctly implemented. I can prove it by debugging. |
| expect(revokeRequests.find(body => body.token_type_hint === 'access_token')).to.eql({ | ||
| 'token_type_hint': 'access_token', | ||
| 'token': 'access token!' | ||
| }); |
There was a problem hiding this comment.
Given the messages of the describe and test this is in, I would assume there's a dedicated test for asserting the access token is invalidated?
| expect(revokeRequests.find(body => body.token_type_hint === 'refresh_token')).to.eql({ | ||
| 'token_type_hint': 'refresh_token', | ||
| 'token': 'refresh token!' | ||
| }); |
There was a problem hiding this comment.
I assume it would be simpler to just wrap the expect in line 340 in an if body.token_type_hint === 'refresh_token'.
Sorry, I think that's what you had originally but I didn't fully understand the issue before…
candunaj
force-pushed
the
fix-authenticator-invalidate-test
branch
from
a253371
to
e464740
Compare
delete-merged-branch
bot
deleted the
fix-authenticator-invalidate-test
branch
Issue
The unit test was testing the authenticator.invalidate method. It is calling revoke endpoint twice. One time revoke refresh_token and the second time revoke access_token. Unit test expected only one request for refresh_token. Call for revoke access_token was not expected and was failing quietly.
Fix
When the fake revoke endpoint is called, only the refresh token is validated.