findTargetElement does not accept SVGElement

[adriancooney]

If I pass an SVGElement into assert.dom(<svg element>) and try to run any assertions, it fails because it requires a HTMLElement explicitly. Maybe move up the inheritance chain in the instanceof check to Element rather than HTMLElement?

let svgElement = document.querySelector("svg"); // Element retrieved manually because too complicated for selector
assert.dom(svgElement).hasAttribute("width", "100");

Throws:

TypeError: Unexpected Parameter: [object SVGGElement]
--
  | at DOMAssertions.findTargetElement (http://localhost:7357/assets/test-support.js:22780:15)
  | at DOMAssertions.hasAttribute (http://localhost:7357/assets/test-support.js:22285:26)
  | at Object._callee21$ (http://localhost:7357/assets/tests.js:140150:76)
  | at tryCatch (http://localhost:7357/assets/vendor.js:10983:40)
  | at Generator.invoke [as _invoke] (http://localhost:7357/assets/vendor.js:11274:22)
  | at Generator.prototype.(anonymous function) [as next] (http://localhost:7357/assets/vendor.js:11035:21)
  | at step (http://localhost:7357/assets/tests.js:139513:32)
  | at http://localhost:7357/assets/tests.js:139524:15
  | at <anonymous>

[Turbo87]

Maybe move up the inheritance chain in the instanceof check to Element rather than HTMLElement?

yeah that sounds like a good solution. can you open a pull request?

[adriancooney]

Thanks for the reply @Turbo87. Sure! Just threw one together here: #76