Feat: add PSM checklists #34
Conversation
| - [ ] `DssLitePsmMom` is added to the chainlog and `addresses_mainnet.sol` according to the Exec Sheet | ||
| - [ ] `LitePsmJob` is added to the chainlog and `addresses_mainnet.sol` according to the Exec Sheet | ||
| - [ ] IF a new `pip` is being added, it is added to the chainlog and `addresses_mainnet.sol` as `PIP_{TOKEN_SYMBOL}` (i.e. `PIP_USDC`) | ||
| - Test coverage: |
There was a problem hiding this comment.
Can we please add end-to-end test here to check main functionally of the DssLitePsm?
As far as I can see, PSMs are not tested by any of the base tests, and testPSMs have to be specifically extended to call _checkPsmIlkIntegration for this each PSM.
There was a problem hiding this comment.
Good point.
_checkPsmIlkIntegration is not LitePSM friendly, it assumes there will be clip and a gemJoin for all PSMs.
Maybe a simple test to buy and sell gems with it would suffice. Not sure if it would belong in the base tests though.
There was a problem hiding this comment.
Since we expect to deploy more LitePSM modules in the future, I think it makes sense to add a base test to do most of the checks described in the Test coverage. Having a checklist is good, but having a base/reusable/configurable test is even better in my opinion.
No description provided.