Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of Docker images #612

Open
9 tasks
emanuelen5 opened this issue Jan 4, 2025 · 0 comments
Open
9 tasks

Bump versions of Docker images #612

emanuelen5 opened this issue Jan 4, 2025 · 0 comments
Labels
legacy Old stuff that might need updating or refactoring

Comments

@emanuelen5
Copy link
Member

We have a bunch of old revisions of the Docker images. This means we have an old Python version, and prevents us from installing some up-to-date NPM packages.

There are several Docker files that need to be looked over, see below. What needs to be done:

  1. Run the Docker bump script scripts/update-docker-images.py. This should use the latest patches of the image tags.
  2. Update to more recent tags of the Docker images (e.g. node:19-alpine -> node:23-alpine). This makes sure we have the latest major/minor revisions of given image.

admin

Build Dockerfile

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/admin/Dockerfile

  • Update node:19-alpine to something more recent. Latest is node:23-alpine
  • Update nginx:alpine SHA. It probably has a newer version

Dev server Dockerfile

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/admin/DevServerDockerfile

  • Update node:19-alpine to something more recent. Latest is node:23-alpine. ⚠️ Must use the same SHA as the Dockerfile that is used when building (which it currently does).

api

Build Dockerfile

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/api/Dockerfile

Test Dockerfile

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/api/TestDockerfile

  • This file uses another SHA for the python:3.11-alpine. ⚠️ Must use the same SHA as the Dockerfile that is used when building (which it currently isn't!).
  • Synchronize the SHA with the Dockerfile that is used for building. Bonus points for creating a script that ensures that they stay in sync (i.e. a test). 💁

public

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/public/Dockerfile

  • Update python:3.11-alpine to the latest Python version, like python:3.13-alpine.

Docker compose file

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/docker-compose.yml

  • Check if mysql:8.0.33 is the most recent, and otherwise update it.

docs

https://github.com/makerspace/makeradmin/blob/b3cb6c1eddbee5c68d3c6b5e8962223677766ff9/docs/Dockerfile

  • Update python:3.11-alpine to the latest Python version, like python:3.13-alpine.
@emanuelen5 emanuelen5 added the legacy Old stuff that might need updating or refactoring label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Old stuff that might need updating or refactoring
Projects
None yet
Development

No branches or pull requests

1 participant