Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version vs CMake project versions mismatch #305

Open
francocipollone opened this issue Sep 12, 2023 · 3 comments
Open

Package version vs CMake project versions mismatch #305

francocipollone opened this issue Sep 12, 2023 · 3 comments

Comments

@francocipollone
Copy link
Collaborator

Summary

What the title says. Root CMakeLists file across all the repository doesn't match with the version stated in the package xml

@francocipollone
Copy link
Collaborator Author

Context

ament_package() call at the end of the root CMakeList file in each package is getting the version information from the package.xml file

https://github.com/ament/ament_cmake/blob/rolling/ament_cmake_core/cmake/core/ament_package_xml.cmake#L83-L88

In a way that the version stated in the root CMakeFile: e.g: project(maliput LANGUAGES C CXX VERSION 3.0.0) won't be
used and will be replaced by the one obtained from package XML.

Proposal

With this context the simplest solution here would be to remove the VERSION field in the project command in all the packages:
e.g: project(maliput LANGUAGES C CXX VERSION 3.0.0) --> project(maliput LANGUAGES C CXX)

@francocipollone
Copy link
Collaborator Author

wdyt @agalbachicar

@agalbachicar
Copy link
Collaborator

I would rather prefer to keep them both in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Inbox
Development

No branches or pull requests

2 participants