Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip: consider adding default duration, iteration, delay for the init method / constructor + add the rootMargin also as an option #13

Open
hidegh opened this issue Dec 14, 2022 · 0 comments

Comments

@hidegh
Copy link

hidegh commented Dec 14, 2022

These global settings should be then overridable via the data elements.
defaults:

  • 1.5 ~ 2 sec duration
  • iteration = 1
  • repeatOnScroll = true | false ❗new option, if true whenever the element scrolls into view, the animation should be played again (default in case of AOS.js)
  • no delay

Should replace #1, #11 too.


Otherwise great, simple and clean code! I like it! 👍

Since AOS uses own styles and has a lot of issues,
So does WOW.js,
And neither of them is alive,

This could be a solution, especially with the animate.css!

Please keep the solution simple, easy to read! I was desperate and to either use wow.js or create one with intersection and mutation observer, but thanx to you, I just can focus on real productive work.

Maybe you should add a call to developers who use it to STAR it on GH and eventually give a great word on social media by writing a simple post, etc. I surely will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant