EIP 684: Prevent overwriting contracts #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with contract creation that could overwrite contracts. The solution is to check for a positive nonce or nonempty code hash in the account that is about to be created. If that's the case, the contract creation needs to fail instead of overwriting the account. For more information see ethereum/EIPs#684
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
There was an issue with contract creation that could result in contracts being
overwritten. The solution is to check for a positive nonce or nonempty code
hash in the account that is about to be created. If that's the case, the
contract creation needs to fail instead of overwriting the account.
For more information see ethereum/EIPs#684
This also closes #357