Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: Close terminal buffer with EXIT signal #324

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

HollowMan6
Copy link
Contributor

@HollowMan6 HollowMan6 commented Jul 2, 2020

When the server is about to close, it will send "Closing" to the front-end. Then on receiving that infomation, the front-end will close using window.close()

app/terminal/index.html Outdated Show resolved Hide resolved
app/terminal/buffer.py Outdated Show resolved Hide resolved
@MatthewZMD
Copy link
Member

这整个写复杂了,关键点是window.close(),还有server.js文件

@HollowMan6
Copy link
Contributor Author

感谢提醒,一开始没想到用window.close()可以直接关闭

@MatthewZMD MatthewZMD merged commit c0b1486 into emacs-eaf:master Jul 3, 2020
@MatthewZMD
Copy link
Member

可以的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants