Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF-viewer: Calculate overlaps when excluding images #365

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

HollowMan6
Copy link
Contributor

@HollowMan6 HollowMan6 commented Aug 4, 2020

With this patch, now my CV can be displayed correctly using PDF-Viewer under dark mode

Further optimize dark mode image excluding algorithms in PDF viewer in #308 by reinverting overlaps if pictures have overlaps.

Previous Current

Complicated Cases:

3 layers' overlap : 2.pdf

image

4 layers' overlap : 3.pdf

image

4.pdf

image

Signed-off-by: Hollow Man hollowman186@vip.qq.com

Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
@HollowMan6 HollowMan6 marked this pull request as draft August 4, 2020 11:51
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
Signed-off-by: Hollow Man <hollowman186@vip.qq.com>
@HollowMan6 HollowMan6 marked this pull request as ready for review August 4, 2020 14:55
@HollowMan6 HollowMan6 changed the title PDF-viewer: Calculate overlaps when exclude images PDF-viewer: Calculate overlaps when excluding images Aug 4, 2020
@MatthewZMD MatthewZMD merged commit 24f761c into emacs-eaf:master Aug 4, 2020
@MatthewZMD
Copy link
Member

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants