Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improperly handling lazy loading of content. #8

Open
mmangione opened this issue Jul 12, 2020 · 1 comment
Open

Improperly handling lazy loading of content. #8

mmangione opened this issue Jul 12, 2020 · 1 comment

Comments

@mmangione
Copy link

mmangione commented Jul 12, 2020

This plugin fails on pages that load some content after landing and fails to process any loading after a 301 or 302. I suspect it is now confused about the origin of the request. We should probably still process requests from domains where we reside - and that are permitted by the CSP of the page or server.

Try to use this plugin to visit Twitter or Facebook. You'll see the issue right away.

@mmangione
Copy link
Author

I suggest we can fix this by changing this :

if (details.initiator !== location.origin.toString()) { ... }

to this:

if (details.initiator !== location.origin.toString() && details.type !== 'xmlhttprequest') {...}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant