New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_segment_for_pe in IDA extractor does unnecessary search #1333

Closed

xusheng6 opened this issue Feb 28, 2023 · 1 comment · Fixed by #1344

Assignees

Labels

Contributor

xusheng6 commented Feb 28, 2023 •

edited

Loading

I think there is no need to push the next address into the todo list at https://github.com/mandiant/capa/blob/master/capa/features/extractors/ida/file.py#L64-L65, since we have already found all mzx at https://github.com/mandiant/capa/blob/master/capa/features/extractors/ida/file.py#L41-L44

The text was updated successfully, but these errors were encountered:

williballenthin assigned mike-hunhoff

williballenthin added the ida-explorer label

mike-hunhoff mentioned this issue

explorer: improve embedded PE detection #1344

Merged

Collaborator

mike-hunhoff commented Mar 3, 2023

Nice catch @xusheng6 ! I've addressed this in #1344

williballenthin closed this as completed in #1344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment