Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ruby 3.x #3

Merged
merged 21 commits into from
Oct 17, 2023
Merged

Upgrade to Ruby 3.x #3

merged 21 commits into from
Oct 17, 2023

Conversation

qwcode
Copy link

@qwcode qwcode commented Sep 27, 2023 •
edited
Loading

  • Upgrades the head of the thoughtworks clone to Ruby 3.x
  • changes the name to man_eb_deployer
  • adds Tests and Release GHA workflows.

duckpuppy
duckpuppy requested changes Sep 27, 2023
View reviewed changes
eb_deployer.gemspec Outdated Show resolved Hide resolved
@qwcode qwcode requested a review from duckpuppy September 27, 2023 15:29
codezninja
codezninja approved these changes Sep 28, 2023
View reviewed changes
Copy link

@codezninja codezninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just had that one workflow change unless we plan on updating to main

.github/workflows/release.yml Outdated Show resolved Hide resolved
@qwcode qwcode merged commit c560d30 into master Oct 17, 2023
1 check passed
@qwcode qwcode deleted the upgrade_ruby_3 branch October 25, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codezninja codezninja codezninja approved these changes

@jeremiahlukus jeremiahlukus Awaiting requested review from jeremiahlukus

@duckpuppy duckpuppy Awaiting requested review from duckpuppy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwcode @duckpuppy @codezninja @jeremiahlukus