Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Improve confusing Jenkinsfile naming references in testing #335

Closed
kmanning opened this issue Feb 9, 2021 · 1 comment · Fixed by #336
Closed

Testing: Improve confusing Jenkinsfile naming references in testing #335

kmanning opened this issue Feb 9, 2021 · 1 comment · Fixed by #336

Comments

@kmanning
Copy link
Collaborator

kmanning commented Feb 9, 2021

original is not a great name, and confounding it with DummyJenkinsfile and Jenkinsfile is even worse. Do something about this.

@kmanning kmanning changed the title Testing: Rename DummyJenkinsfile to something more sensible Testing: Improve confusing Jenkinsfile naming references in testing Feb 9, 2021
@kmanning
Copy link
Collaborator Author

kmanning commented Feb 9, 2021

Solution:

  • this in Jenkinsfile.init(this) is a WorkflowScript
  • Rename DummyJenkinsfile to MockWorkflowScript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant