Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PullRequest templates, with a list of tasks to complete before merging #399

Closed
kmanning opened this issue Jul 29, 2021 · 0 comments · Fixed by #401
Closed

Add PullRequest templates, with a list of tasks to complete before merging #399

kmanning opened this issue Jul 29, 2021 · 0 comments · Fixed by #401
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@kmanning
Copy link
Collaborator

I'd like it to be clear for any contributor, what needs to be done before merging a pull request. Let's add a checklist template to PullRequests, so that the PR author can check each task as they're complete.

Things that should be in the list:

  • Have you linked this Pull Request to an Issue?
  • Have you updated any relevant README files, to explain how this new feature works (with examples)?
  • Have you added relevant test cases for your change?
  • Do all tests and code style checks pass with ./gradlew check --info?
  • Have you successfully run your change in a pipeline in a Jenkins instance?
  • Have you updated the CHANGELOG?
@kmanning kmanning added this to the v5.18 milestone Jul 29, 2021
@kmanning kmanning added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 29, 2021
@kmanning kmanning linked a pull request Aug 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant