feat: 🎸 unfoldSaga return success data

manhhailua · Sep 28, 2019 · 2f89269 · 2f89269
1 parent fd31ecc
commit 2f89269
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -163,10 +163,11 @@ export function* unfoldSaga(
   { handler, key }: UnfoldSagaHandlerType,
   { onBeginning = noop, onFailure = noop, onFinish = noop, onSuccess = noop }: UnfoldSagaCallbacksType = {},
 ): any {
+  let data;
+
   try {
     yield put({ type: createActionTypeOnBeginning(key) });
     yield call(onBeginning);
-    let data;
     if (['GeneratorFunction', 'AsyncGeneratorFunction'].includes(handler.constructor.name)) {
       data = yield* handler();
     } else {
@@ -181,6 +182,8 @@ export function* unfoldSaga(
     yield put({ type: createActionTypeOnFinish(key) });
     yield call(onFinish);
   }
+
+  return data;
 }
 
 export default {

diff --git a/test/unfoldSagaAsync.test.js b/test/unfoldSagaAsync.test.js
@@ -75,6 +75,7 @@ describe('unfoldSaga for async handler', () => {
     test('should end', () => {
       result = generator.next();
       expect(result.done).toBe(true);
+      expect(result.value).toBe(fakeResult);
     });
   });
 

diff --git a/test/unfoldSagaGenerator.test.js b/test/unfoldSagaGenerator.test.js
@@ -86,6 +86,7 @@ describe('unfoldSaga for generator handler', () => {
     test('should end', () => {
       result = generator.next();
       expect(result.done).toBe(true);
+      expect(result.value).toBe(fakeResult);
     });
   });