Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ProvisionOnDemand to return OK as response #226

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

iwarapter
Copy link
Contributor

SynchronizationJobClient.BaseClient.Post(): unexpected status 200 with response:

If provision runs on a group thats already provisioned you will get a message like this:

The state of the entry in both the source and target systems already match. No change to the Group 'example' currently needs to be made.

As such a 200 shouldn't be treated as a failure

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iwarapter, this LGTM 👍

@manicminer manicminer added this to the v0.59.0 milestone Feb 27, 2023
@manicminer manicminer merged commit d0a8bfd into manicminer:main Feb 27, 2023
manicminer added a commit that referenced this pull request Feb 27, 2023
@iwarapter iwarapter deleted the patch-1 branch February 27, 2023 21:12
@iwarapter
Copy link
Contributor Author

Thanks @manicminer, i have a draft PR for the azure provider to use this, if you have a few minutes to look at the questions - hashicorp/terraform-provider-azuread#1032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants