Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AccessPackageResourceRoleClient #278

Merged

Conversation

Varantha
Copy link
Contributor

@Varantha Varantha commented Mar 9, 2024

Hey,

Hope you don't mind a random PR.

This aims to implement this method into hamilton:

https://learn.microsoft.com/en-us/graph/api/accesspackagecatalog-list-accesspackageresourceroles?view=graph-rest-beta&tabs=http

This will list all the possible roles available for selection for a specific resource in a specific access package catalog.

This is a requirement to be able to solve this issue on the azuread provider:

hashicorp/terraform-provider-azuread#1066

The API is pretty weird and if you omit any of the OData parameters then it won't work correctly so it's just the one, quite specific method.

Let me know if you need anything else from me on this 😃

@manicminer manicminer self-requested a review March 28, 2024 01:13
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Varantha, it is very welcomed!

Given the rather specific nature of this API's behavior, I think your implementation is fine. The relevant tests are passing and this looks good to merge. Thanks again!

@manicminer manicminer added enhancement New feature or request package/msgraph labels Mar 28, 2024
@manicminer manicminer merged commit 6e80ce0 into manicminer:main Mar 28, 2024
1 of 2 checks passed
manicminer added a commit that referenced this pull request Mar 28, 2024
@manicminer manicminer added this to the v0.67.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants