Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedLocations: Set OData types in UpdateCountry / UpdateIP functions #55

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

kaovd
Copy link
Contributor

@kaovd kaovd commented May 28, 2021

The Odata type assignment is missed in the update functions which causes the requests to be ill formed and updates are not applied. See hashicorp/terraform-provider-azuread#441

The Odata type functions are missed in the update functions which causes the requests to be ill formed and updates are not applied. See hashicorp/terraform-provider-azuread#441
@kaovd kaovd changed the title Set OData types in UpdateCountry / UpdateIP functions NamedLocations: Set OData types in UpdateCountry / UpdateIP functions May 28, 2021
@manicminer manicminer added the bug Something isn't working label Jun 1, 2021
@manicminer manicminer added this to the v0.15.0 milestone Jun 1, 2021
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaovd. I think we can probably make constants out of these API type strings, but this is OK for now 👍

@manicminer manicminer merged commit 131b2b3 into manicminer:main Jun 1, 2021
manicminer added a commit that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants