Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifold-graphql: larger graphql models will not compile due to graphql-java default 15000 token limit #536

Closed
rsmckinney opened this issue Dec 14, 2023 · 1 comment
Labels

Comments

@rsmckinney
Copy link
Member

graphql-java parser added a default token limit of 15000 (to address DoS), one manifold-sql customer has graphql models that exceed this limit, which causes graphql compilation failure.

Since manifold parses graphql exclusively at compile time, this limit can be ignored, thus we can make it sufficiently large as to never reach it in practice. Other runtime specific limits may need addressing as well. See ParserOptions.newParserOptions().

@rsmckinney rsmckinney added the bug label Dec 14, 2023
rsmckinney added a commit that referenced this issue Dec 14, 2023
- override java-graphql ParserOptions which are not applicable to compile-time use e.g., maxTokens
@rsmckinney
Copy link
Member Author

Fix available with release 2023.1.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant