Add Storybook VRT #207
Merged
Add Storybook VRT #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
force-pushed
the
dangodev/vrt
branch
2 times, most recently
from
ae13295 to
4dd3337
Compare
markjamieson
approved these changes
May 15, 2020
drwpow
commented
May 15, 2020
| PREVIOUS_SHA: ${{ github.event.before }} | ||
| CHANGE_URL: ${{ github.event.compare }} | ||
| HAPPO_API_KEY: ${{ secrets.HAPPO_API_KEY }} | ||
| HAPPO_API_SECRET: ${{ secrets.HAPPO_API_SECRET }} |
There was a problem hiding this comment.
I’m liking Percy better already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Uses Percy for testing Storybook stories. In the process of getting it set up I noticed a few things:
Also, to get this to work with Percy, I needed to also mock the data rather than use our API. I added a
previewmode to the component, similar to our other ones.Testing
VRT is working again! 🎉
Checklist