Stake tab complete staking is requesting approval

[greg-schrammel]

Describe the bug
Clicking complete stake starts an approval request

I'd guess it's something like input < allowance instead of input <= allowance

as a side note I understand permit as a EIP-2612 signature, I'd suggest changing the button label to approve

[sambacha]

Thanks for reporting this, we are rolling back to a known production state right now while we diagnose this issue. The commit that we are rolling the production dapp back to is 45b3814

[sambacha]

we have added this to the current dev cycle, you can see our project board here: https://github.com/orgs/manifoldfinance/projects/8

[sambacha]

This is using the Brave browser, correct?

[greg-schrammel]

yes, it's brave

[0xgeert]

hey @sambacha: was bitten by this as well.

See here for the xfold approve that doesn't need to be there as part of the mint

Also, the foldNeedsApproval code is not correct, since it only returns true if approved amount to the xfold address is zero, instead of anything smaller than the value the user wants to mint. This resulted in met not seeing the Permit FOLD to mint and stake xFOLD-button and thus getting a failing mint as a result.

I suggest just doing an approve of Fold instead of xFold as part of the mint for the specified amount and you're done.

[sambacha]

hey @sambacha: was bitten by this as well.

See here for the xfold approve that doesn't need to be there as part of the mint

Also, the foldNeedsApproval code is not correct, since it only returns true if approved amount to the xfold address is zero, instead of anything smaller than the value the user wants to mint. This resulted in met not seeing the Permit FOLD to mint and stake xFOLD-button and thus getting a failing mint as a result.

I suggest just doing an approve of Fold instead of xFold as part of the mint for the specified amount and you're done.

Thanks for the details, how can we award you a bounty?

The current version issue is we do not have the bandwidth to address these issues , so if you want to get paid for fixing them just name a reasonable price

the entire dapp needs to be rewritten iMho, but that can obviously wait