Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding react-native/no-raw-text when when it becomes more stable #113

Open
bmitchinson opened this issue Jul 24, 2019 · 4 comments
Open

Consider adding react-native/no-raw-text when when it becomes more stable #113

bmitchinson opened this issue Jul 24, 2019 · 4 comments
Labels
New Rule On Hold

Comments

@bmitchinson
Copy link

bmitchinson commented Jul 24, 2019 •
edited by manovotny
Loading

Current Open Issue - Here

Wondering if that's enough to remove it from beta of v5 until it's fixed? Currently throwing unnecessary errors for Animated.Text components.
@manovotny
Copy link
Owner

I am open to suggestions... Should we remove the rule completely or add the suggested work around?

@bmitchinson
Copy link
Author

Mostly just wanted to bring its instability into attention, could go either way. 🤷‍♂

Gut feeling would be to disable any rule that's not stable in all contexts.

@manovotny manovotny changed the title Consider adding react-native/no-raw-text when it's supported inside <Animated.Text> Consider adding react-native/no-raw-text when when it becomes more stable Jul 30, 2019
@manovotny
Copy link
Owner

I agree with you. It's probably wise to wait for stability.

It's been removed in 5.0.0-beta.6.

@manovotny
Copy link
Owner

Upstream issue still exists. Still holding on adoption for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New Rule On Hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manovotny @bmitchinson