From bd81305738e5003129466e2940a9e46508212654 Mon Sep 17 00:00:00 2001
From: Aravindh Puthiyaparambil <aravindh@redhat.com>
Date: Thu, 12 Oct 2023 14:14:26 -0700
Subject: [PATCH] Change imagePullPolicy for olm.sh

Change the imagePullPolicy for "olm.sh run" to Always. This is needed to
ensure that the latest image is always pulled. Revert to IfNotPresent
on "olm.sh cleanup".
Remove the extra quotes from the sed command which was mangling the
strings.
---
 hack/common.sh | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/hack/common.sh b/hack/common.sh
index 4836f86b6..eddf11f65 100644
--- a/hack/common.sh
+++ b/hack/common.sh
@@ -224,6 +224,7 @@ run_WMCO() {
   fi
 
   transform_csv REPLACE_IMAGE $OPERATOR_IMAGE
+  transform_csv "imagePullPolicy: IfNotPresent" "imagePullPolicy: Always"
 
   # Validate the operator bundle manifests
   $OSDK bundle validate $MANIFEST_LOC
@@ -279,10 +280,10 @@ cleanup_WMCO() {
 
   # Cleanup the operator and revert changes made to the csv
   if ! OSDK_WMCO_management cleanup $OSDK; then
-      transform_csv $OPERATOR_IMAGE REPLACE_IMAGE
+      revert_csv
       error-exit "operator cleanup failed"
   fi
-  transform_csv $OPERATOR_IMAGE REPLACE_IMAGE
+  revert_csv
 
   # Remove the declared namespace
   oc delete ns $WMCO_DEPLOY_NAMESPACE
@@ -297,7 +298,13 @@ transform_csv() {
     echo incorrect parameter count for replace_csv_value $#
     return 1
   fi
-  sed -i "s|"$1"|"$2"|g" $MANIFEST_LOC/manifests/windows-machine-config-operator.clusterserviceversion.yaml
+  sed -i "s|$1|$2|g" $MANIFEST_LOC/manifests/windows-machine-config-operator.clusterserviceversion.yaml
+}
+
+# Revert the CSV back to it's original form
+revert_csv() {
+    transform_csv $OPERATOR_IMAGE REPLACE_IMAGE
+    transform_csv "imagePullPolicy: Always" "imagePullPolicy: IfNotPresent"
 }
 
 # creates the `windows-instances` ConfigMap