Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all matplotlib version checks from source. #34650

Closed
thomashampson opened this issue Oct 31, 2022 · 0 comments · Fixed by #35311
Closed

Remove all matplotlib version checks from source. #34650

thomashampson opened this issue Oct 31, 2022 · 0 comments · Fixed by #35311
Assignees
@sf1919
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@thomashampson
Copy link
Contributor

Describe the outcome that is desired.
Now that our packaged matplotlib version is consistent across all operating systems, we no longer need to support multiple versions.

Describe any solutions you are considering
Remove all matplotlib version checks from source code. There are a lot of places where different functions/attributes are called based on matplotlib version checks. These are no longer needed.

Additional context
e.g. if LooseVersion(matplotlib.__version__) <= LooseVersion("3.1.3"):
@thomashampson thomashampson added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Oct 31, 2022
@thomashampson thomashampson self-assigned this Oct 31, 2022
@sf1919 sf1919 mentioned this issue Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sf1919 sf1919

Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
No open projects
Release 6.7 ISIS Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove matplotlib version checks mantidproject/mantid
2 participants
@thomashampson @sf1919