Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more PEP 440 version numbering schema #35342

Closed
thomashampson opened this issue Mar 7, 2023 · 0 comments · Fixed by #35357
Closed

Support more PEP 440 version numbering schema #35342

thomashampson opened this issue Mar 7, 2023 · 0 comments · Fixed by #35357
Assignees
@thomashampson @jhaigh0
Labels
Added during Sprint Tasks that were added after initial sprint planning ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone
Release 6.7

Comments

@thomashampson
Copy link
Contributor

thomashampson commented Mar 7, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently when building a release candidate with a version number of the form X.Y.ZrcN, CheckMantidVersion algorithm will not work correctly. It will also try to display the help documentation for X.Y+1.0, which will not exist on the release-next branch so will cause a crash.
The same is true for a version number like X.Y.Z+somestring.

Describe the solution you'd like
Support the following additional types of version number:

  • X.Y.Z+somestring (this is the only PEP 440 compliant way I've found of adding a custom string to the version number)
  • X.Y.ZrcN

so that the X.Y.Z help documentation is displayed and CheckMantidVersion does not complain if X.Y.Z is the latest version.

Additional context
https://peps.python.org/pep-0440/#local-version-identifiers
@thomashampson thomashampson added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Mar 7, 2023
@thomashampson thomashampson added this to the Release 6.7 milestone Mar 7, 2023
@thomashampson thomashampson added the Added during Sprint Tasks that were added after initial sprint planning label Mar 7, 2023
@thomashampson thomashampson changed the title Support PEP 440 version numbering Support more PEP 440 version numbering schema Mar 7, 2023
@thomashampson thomashampson mentioned this issue Mar 10, 2023
Merged
@jhaigh0 jhaigh0 moved this to In Progress in Release 6.7 ISIS Core Mar 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Release 6.7 ISIS Core Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomashampson thomashampson

@jhaigh0 jhaigh0

Labels
Added during Sprint Tasks that were added after initial sprint planning ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
No open projects
Release 6.7 ISIS Core
Status: Done
Milestone
Release 6.7
Development

Successfully merging a pull request may close this issue.

Support more PEP440 version numbers mantidproject/mantid
2 participants
@thomashampson @jhaigh0