Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Variation struct and set_variations function #32

Merged
merged 6 commits into from
Aug 28, 2021
Merged

add Variation struct and set_variations function #32

merged 6 commits into from
Aug 28, 2021

Conversation

Yoxem
Copy link
Contributor

@Yoxem Yoxem commented Aug 28, 2021

see issue #31.

@Yoxem Yoxem mentioned this pull request Aug 28, 2021
Closed
@manuel-rhdt
Copy link
Collaborator

Thank you for this pull request, I added a few small comments. When you address them I can merge this.

@Yoxem
Copy link
Contributor Author

Yoxem commented Aug 28, 2021

I have modified the code, and hope it can be more user-friendly.

@manuel-rhdt
Copy link
Collaborator

Thanks!

@manuel-rhdt manuel-rhdt merged commit 283aa27 into harfbuzz:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yoxem @manuel-rhdt