Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sexagesimalToDecimal() trim whitespace #278

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Make sexagesimalToDecimal() trim whitespace #278

merged 1 commit into from
Oct 11, 2021

Conversation

PaulCapron
Copy link
Contributor

@PaulCapron PaulCapron commented Oct 6, 2021 •
edited
Loading

This is for consistency with isSexagesimal(), which trim() (starting & trailing whitespaces) from its input.

Fixes #254.

@PaulCapron
Make sexagesimalToDecimal() trim whitespace
f8657f0 
This is for coherency with isSexagesimal(), which does trim starting&trailing whitespace from its input.
@manuelbieh manuelbieh merged commit 3827a8f into manuelbieh:master Oct 11, 2021
manuelbieh pushed a commit that referenced this pull request Oct 11, 2021
@semantic-release-bot
release: 3.3.3 - 2021-10-11T15:43:29.800Z [skip ci]
35ac298 
### [3.3.3](v3.3.2...v3.3.3) (2021-10-11)

### 🔧 Fixes

* ignore whitespaces in sexagesimal patterns. fixes [#254](#254) ([47850ea](47850ea))
* increase accuracy ([2a7b443](2a7b443))
* Merge pull request [#278](#278) from PaulCapron/patch-1 ([3827a8f](3827a8f))
@manuelbieh
Copy link
Owner

🎉 This PR is included in version 3.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@PaulCapron
Copy link
Contributor Author

Super, thanks!

@PaulCapron PaulCapron deleted the patch-1 branch October 11, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incoherence between sexagesimalToDecimal and isSexagesimal
2 participants
@PaulCapron @manuelbieh