Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is gradle 8.10.2 supported #48

Closed
marwin1991 opened this issue Jan 14, 2025 · 8 comments
Closed

is gradle 8.10.2 supported #48

marwin1991 opened this issue Jan 14, 2025 · 8 comments

Comments

@marwin1991
Copy link

Hello,

cool project

Is it gradle 8.10.2 supported ?

@marwin1991
Copy link
Author

@manusa

@manusa
Copy link
Owner

manusa commented Jan 15, 2025

Yes, it should be supported.

@marwin1991
Copy link
Author

@manusa you should extend readme about available version.gradle values, because I understand that i cannot use any version?

@manusa
Copy link
Owner

manusa commented Jan 15, 2025

Quite the opposite, you should be able to use any Gradle 7 or Gradle 8 version.

you should extend readme about available

Do you want to open a PR to clarify that?

I guess something could be added after the block where it states: Add a fake dependency to your project with the version of Gradle you want to use.

@marwin1991
Copy link
Author

marwin1991 commented Jan 17, 2025

@manusa

I have notice, that if i used:

        <dependency>
            <groupId>org.gradle</groupId>
            <artifactId>gradle-all</artifactId>
            <version>${gradle-all.version}</version>
        </dependency>

I got error during importing this dep:

A problem occurred configuring root project 'demo'.
> Could not resolve all artifacts for configuration 'classpath'.
   > Could not find org.gradle:gradle-all:8.2.1.
     Searched in the following locations:
       - https://plugins.gradle.org/m2/org/gradle/gradle-all/8.2.1/gradle-all-8.2.1.pom
     Required by:
         root project : > dev.logchange:dev.logchange.gradle.plugin:1.16.3

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

I guess <scope>test</scope> it is important then?

Maybe you could add to readme:

<!-- It's important to add this as test, because otherwise importing this plugin will require such a dependency, what will cause an error -->

test does not work, becasue I cannot refer gradle classes like import org.gradle.api.Project; i will test provided

@manusa
Copy link
Owner

manusa commented Jan 18, 2025

The scope should most likely be test or provided but it depends a lot on your use case (however, I don't think this should be causing an issue --I need to check--).

For example, I mostly use this extension maven plugin to be able to create Gradle plugins from Maven Projects:

In both cases, the fake dependency is added as provided since the plugin will actually run within a Gradle environment which will provide the actual dependencies.

Let me know how are you using the plugin and we can clarify how to add the dependency or see if there's something else to be implemented.

@marwin1991
Copy link
Author

@manusa thank you so much for help and for creating this awesome plugin!

I am also creating gradle plugin:

https://github.com/logchange/logchange/tree/main/logchange-gradle-plugin

And I was struggling, but provided works like a charm!

Maybe you should release this plugin as 1.0.0 because looks nice and production ready :)

@manusa
Copy link
Owner

manusa commented Jan 20, 2025

Awesome news! 🚀

Maybe you should release this plugin as 1.0.0 because looks nice and production ready :)

That's a discussion for another day.
But I can guarantee that the plugin is production-ready since day one, been using it flawlessly in major libraries 😅

I'm closing this issue now.
Feel free to open a new issue or to reach out in case you have any problem with your gradle plugin.

@manusa manusa closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants