Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not working #185

Open
q-wertz opened this issue Mar 27, 2023 · 9 comments
Open

Search not working #185

q-wertz opened this issue Mar 27, 2023 · 9 comments

Comments

@q-wertz
Copy link

q-wertz commented Mar 27, 2023

System

  • OS: Manjaro Linux
  • Your version of the extension (visible in the "about" tab of the preferences window): 0 in preferences window (AUR package gnome-shell-extension-emoji-selector-git, so should be most recent version). Also tried the version from gnome extension store with same result.
  • Your version of GNOME Shell: 43.3
  • Most recent GNOME Shell version that is supposed to work (visible here in the dropdown): 43
  • Is the extension supposed to work with your version of GNOME Shell [y/n]: y

Description of the bug

Is your bug already reported? [y/n]: n

To Reproduce

Steps to reproduce the bug:

  1. Install and activate the extension
  2. Click on the menu entry, start typing e.g. heart
  3. Nothing happens

Expected behavior

  • A selection of matching emojis in the line below and one of them can be selected
@rapenne-s
Copy link

I can reproduce it as well on OpenSuse MicroOS using #186 on Gnome 44

@VortexAcherontic
Copy link

VortexAcherontic commented Apr 12, 2023

That’s strange as for me, also MicroOS w/ Gnome 44 the extension works just fine including the search:
https://www.youtube.com/watch?v=AM0-bmpZTBc

Maybe some other extension breaking the behaviour for you?

Could you guys please provide some logs?
I may try to incorporate a fix in my PR #186

You can run sudo journalctl -f in a terminal and then do the actions inside the extension to get some logs. It should output the errors there.

Edit: Are you running Wayland or X11?

@rapenne-s
Copy link

rapenne-s commented Apr 12, 2023

That's what I get when using the search, on wayland, and also on X

avril 12 15:31:25 t470 gnome-shell[1521]: JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
                                          searchEmoji@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                          _getResults@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                          _onSearchTextChanged@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
                                          _onSearchTextChanged@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
                                          clearCategories@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
                                          _onOpenStateChanged@/home/solene/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
                                          _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                          _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                          open@resource:///org/gnome/shell/ui/popupMenu.js:927:14
                                          toggle@resource:///org/gnome/shell/ui/popupMenu.js:800:18
                                          vfunc_event@resource:///org/gnome/shell/ui/panelMenu.js:139:23

@q-wertz
Copy link
Author

q-wertz commented Apr 12, 2023

I am using Wayland.

Having the similar error as @rapenne-s

Apr 12 16:11:58 hoth gnome-shell[2175]: JS ERROR: TypeError: results.includes is not a function
                                        searchEmoji@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                        _getResults@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
Apr 12 16:11:58 hoth gnome-shell[2175]: JS ERROR: TypeError: results.includes is not a function
                                        searchEmoji@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                        _getResults@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
Apr 12 16:11:58 hoth gnome-shell[2175]: JS ERROR: TypeError: results.includes is not a function
                                        searchEmoji@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                        _getResults@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
Apr 12 16:11:58 hoth gnome-shell[2175]: JS ERROR: TypeError: results.includes is not a function
                                        searchEmoji@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                        _getResults@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
Apr 12 16:12:01 hoth gnome-shell[2175]: JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
                                        searchEmoji@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
                                        _getResults@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
                                        _onSearchTextChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
                                        clearCategories@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
                                        _onOpenStateChanged@/usr/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
                                        _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                        close@resource:///org/gnome/shell/ui/popupMenu.js:944:14
                                        _onCapturedEvent@resource:///org/gnome/shell/ui/popupMenu.js:1390:18

Additionally I get errors from the org.gnome.shell.extensions.system-monitor extension (maybe related, just here for completeness)

Apr 12 16:11:52 hoth gnome-shell[2175]: JS ERROR: Error: GSettings key tooltip-delay-ms not found in schema org.gnome.shell.extensions.system-monitor
                                        _checkKey@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:733:23
                                        createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:685:30
                                        on_leave@/usr/share/gnome-shell/extensions/system-monitor-next@paradoxxx.zero.gmail.com/extension.js:885:55

@VortexAcherontic
Copy link

Guys, I think I loosing my mind 😅
Tested this extension on two different machines, well kinda, both MicroOS and Gnome 44, but fail to get the same errors.
I even triple checked I am running the same extension but I'm pretty sure I do.

Are there any other extensions you run?
I mean it can't be that 3 people have the exact same issue while I struggle to reproduce it especially since @rapenne-s runs MicroOS as well.

@rapenne-s
Copy link

No other extension.

For installation, I cloned your git repo and run ./install.sh in it.

Could it be a missing font that would also contain more metadata or something like that?

@VortexAcherontic
Copy link

Yes I was finally able to reproduce the issue! 🥳

It seems the source of the actual extension available on extenstion.gnome.org differs a lot more from what is currently in the git-repo.

After installing the extension from the git-repo via the install.sh script I am now getting the same error.
I used the latest release version and just patched the 44 into that one.
It was my fault to expect the latest release to be the same as the latest git-repo commit.

@VortexAcherontic
Copy link

Deployed a fix which is now included in PR #186

@q-wertz
Copy link
Author

q-wertz commented Apr 12, 2023

Thanks a lot for your work 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants