Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify swift version #26

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Specify swift version #26

merged 1 commit into from
Jan 24, 2017

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Jan 24, 2017

Fixes #14

The swiftenv inspired .swift-version-file is flaky despite CocoaPod's claim to support it as of 1.1.0.

This PR removes SWIFT_VERSION from the target and inherits it from the project instead.
It also specifies SWIFT_VERSION in xcconfig just like MapboxDirections.swift.podspec which been proven to work well. These settings will continue to work when we add support for Carthage (#24)

@bsudekum
Copy link
Contributor

👍

@bsudekum bsudekum merged commit 5b8a30c into master Jan 24, 2017
@bsudekum bsudekum deleted the fred-swift-version-14 branch January 24, 2017 16:12
wishtrip-dev pushed a commit to wishtrip-dev/mapbox-navigation-ios that referenced this pull request Feb 28, 2018
…t ability.

Fixes mapbox#26

* Adds `Polyline` pod dependency
MaximAlien pushed a commit that referenced this pull request Feb 19, 2021
* address root cause by replacing userCourseView.update() direction with mapView.bearing in NavigationMapView.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants