Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Directions.accessToken and Directions.apiEndpoint public #308

Closed
1ec5 opened this issue Nov 8, 2018 · 0 comments
Closed

Make Directions.accessToken and Directions.apiEndpoint public #308

1ec5 opened this issue Nov 8, 2018 · 0 comments
Labels
bug

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 8, 2018

The public Directions(accessToken:host:) initializer accepts an access token and API endpoint hostname, but the corresponding accessToken and apiEndpoint properties are internal. It’s awkward for a configuration option to be write-only.

https://github.com/mapbox/MapboxDirections.swift/blob/6bf93daa11ed21b2b31352f199ac1316fb1c287b/MapboxDirections/MBDirections.swift#L93-L97

/cc @mapbox/navigation-ios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1ec5