Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change value of request's language parameter #129

Closed
patjouk opened this issue Jun 9, 2017 · 1 comment
Closed

Change value of request's language parameter #129

patjouk opened this issue Jun 9, 2017 · 1 comment
Milestone

Comments

@patjouk
Copy link

patjouk commented Jun 9, 2017

This PR introduce support for the new language parameter. Right now, it's set to English but It would be great to be able to change it to other languages we support.

I don't think we will need a UI element to change the language, but instead it should be enough to set the language code during initialization (e.g. for a website that only ever will need French instructions) or via a dispatched event (for multi-language websites with external language choosing UI, is that possible?)

@patjouk
Copy link
Author

patjouk commented Nov 17, 2017

Closing this issue. Please, create another one if you want to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants