Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just start from v1.3.0, only the symbol layer will get stuck. Does anyone know what's going on? #10554

Closed
thomashooo opened this issue Apr 10, 2021 · 5 comments

Comments

@thomashooo
Copy link

blow v1.2.0 everything is ok,I had test from v1.3.0~v2.2.0, the symbol layer cannot update immediately ? (on iPhone 8, Especially in old devices)
Here is the demo, You can see the difference more clearly here (the airplane symbol layer update lag, the circle layer is better,It's more different on mobile phones):

test url:

https://thomashooo.github.io/mapboxtest/

test gif:

Does anyone know what's going on, thanks?

@thomashooo
Copy link
Author

Maybe it's the poor performance of the mobile phone, the frequent use of animation, and the performance problems of high mapbox version. But how to follow the camera when symbol layer moving in high version??
map.easeTo({center: point.features[0].geometry.coordinates,
bearing: point.features[0].properties.bearing,
essential: true // this animation is considered essential with respect to prefers-reduced-motion});

@arindam1993
Copy link
Contributor

@thomashooo Could you please retry with v2.2.0? We added #10417 which should have fixed this.

If you still see this, could you please point to a simple code snipped that reproduces the issue?

@mourner mourner closed this as completed Apr 24, 2021
@thomashooo
Copy link
Author

thomashooo commented Apr 26, 2021

@thomashooo Could you please retry with v2.2.0? We added #10417 which should have fixed this.

If you still see this, could you please point to a simple code snipped that reproduces the issue?

@arindam1993 thanks for comment, v2.2.0 still not good as v1.2.0, any ideas?here is comparison,you can see diff just open blow url in safari:
1.2.0 VS 2.2.0: https://thomashooo.github.io/mapboxtest/index.html

simple code(just add a easeTo in official demo: https://docs.mapbox.com/mapbox-gl-js/example/animate-point-along-route/):
//official demo snip: map.getSource('point').setData(point); //simple code map.easeTo({center: point.features[0].geometry.coordinates, bearing:point.features[0].properties.bearing, essential: true });

@mmuelder
Copy link

we also have a poor performance with a smiliar use case and the smybol layer in the sarafi, even the newest version is slower than 1.X

@thomashooo
Copy link
Author

@thomashooo Could you please retry with v2.2.0? We added #10417 which should have fixed this.

If you still see this, could you please point to a simple code snipped that reproduces the issue?

problem still exists in 2.5.1:
https://thomashooo.github.io/mapboxtest/symbolTest.html#v=1.2.0
https://thomashooo.github.io/mapboxtest/symbolTest.html#v=2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants