Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct rotation handling in projections #10742

Closed
ryanhamley opened this issue Jun 3, 2021 · 0 comments · Fixed by #10781
Closed

Correct rotation handling in projections #10742

ryanhamley opened this issue Jun 3, 2021 · 0 comments · Fixed by #10781
Assignees
Milestone

Comments

@ryanhamley
Copy link
Contributor

North was always up on Mercator projections so that a bearing of 0° meant that the map was pointing north. That's not necessarily the case for other projections. We need to create an internal rotation parameter that is disambiguated from bearing and have {get/set}Bearing convert between the rotation and the bearing based on the current map center so that we can retain the connection between bearing and real world compass directions while allowing the map to rotate appropriately based on the projection.

@ryanhamley ryanhamley added this to the projections milestone Jun 3, 2021
@ansis ansis assigned ryanhamley and unassigned ansis Jun 16, 2021
@ryanhamley ryanhamley linked a pull request Jun 16, 2021 that will close this issue
10 tasks
@ansis ansis closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants