Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test interaction handlers, UI controls, and browser utilities #1550

Closed
jfirebaugh opened this issue Sep 24, 2015 · 5 comments
Closed

Test interaction handlers, UI controls, and browser utilities #1550

jfirebaugh opened this issue Sep 24, 2015 · 5 comments

Comments

@jfirebaugh
Copy link
Contributor

Figure out how to test our event handling and interaction modules.

@jfirebaugh
Copy link
Contributor Author

Possible approaches:

  • JSDom. Pro: likely less unpredictability / hard-to-debug timing issues than a browser environment. Con: likely lower fidelity event implementation.
  • Reintroduce real-browser test suite using smokestack. Pro: higher fidelity. Con: https://twitter.com/tmcw/status/646345048142032896
  • Selenium?

@lucaswoj lucaswoj changed the title test event handling Test interaction handlers Mar 10, 2016
@lucaswoj lucaswoj changed the title Test interaction handlers Test interaction handlers and UI controls Mar 11, 2016
@lucaswoj
Copy link
Contributor

screen_shot_2016-03-10_at_5 47 58_pm_1024

@anandthakker
Copy link
Contributor

JSDom. Pro: likely less unpredictability / hard-to-debug timing issues than a browser environment. Con: likely lower fidelity event implementation.

At this point in time, I would vote for this particular tradeoff. I think it would be the quickest way to get started and I'm betting a large majority of these tests would not require a super high fidelity event environment. (E.g. #2972 )

@lucaswoj lucaswoj changed the title Test interaction handlers and UI controls Test interaction handlers, UI controls, and browser utilities Aug 25, 2016
@lucaswoj
Copy link
Contributor

lucaswoj commented Aug 25, 2016

+ browser utilities (i.e. js/util/browser/*.js) 😄

@jfirebaugh
Copy link
Contributor Author

We've been gradually filling these out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants