Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CI builds for branches in 3rd party repositories build successfully #2465

Closed
lucaswoj opened this issue Apr 19, 2016 · 5 comments
Closed

Comments

@lucaswoj
Copy link
Contributor

ref #2453

@mourner
Copy link
Member

mourner commented Apr 20, 2016

I know remember that there was a known limitation to PR branches on Circle, but @jfirebaugh should know more.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Apr 20, 2016

This looks like Coverall's fault. If there isn't an easy solution, I think we should ignore errors from the coveralls CLI.

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Apr 20, 2016

lemurheavy/coveralls-public#632 and lemurheavy/coveralls-public#487 suggest some troubleshooting steps.

@lucaswoj lucaswoj modified the milestone: v1.0.0 Jun 29, 2016
@lucaswoj lucaswoj added the v1 label Jul 28, 2016
@lucaswoj lucaswoj removed this from the v1.0.0 milestone Jul 28, 2016
@lucaswoj
Copy link
Contributor Author

Looks like we need to set COVERALLS_REPO_TOKEN in our CI environment. I have mitigated the problem temporarily by preventing a coveralls error from causing the build to fail.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Dec 5, 2016

I researched this a little further and found that CircleCI intentionally omits environment variables from forked builds. It even says so in the build log:

screen shot 2016-12-05 at 3 33 53 pm

The only way we could enable coveralls for forked builds is to make our coveralls repo token public.

As a compromise, I have removed "coveralls" from the list of required checks.

Long term: I wonder if we can hook the coverage stats into our benchmarking system #1362 to get around this design flaw in coveralls using a similar approach as #3495.

@lucaswoj lucaswoj closed this as completed Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants