-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure CI builds for branches in 3rd party repositories build successfully #2465
Comments
I know remember that there was a known limitation to PR branches on Circle, but @jfirebaugh should know more. |
This looks like Coverall's fault. If there isn't an easy solution, I think we should ignore errors from the coveralls CLI. |
lemurheavy/coveralls-public#632 and lemurheavy/coveralls-public#487 suggest some troubleshooting steps. |
Looks like we need to set |
I researched this a little further and found that CircleCI intentionally omits environment variables from forked builds. It even says so in the build log: The only way we could enable coveralls for forked builds is to make our coveralls repo token public. As a compromise, I have removed "coveralls" from the list of required checks. Long term: I wonder if we can hook the coverage stats into our benchmarking system #1362 to get around this design flaw in coveralls using a similar approach as #3495. |
ref #2453
The text was updated successfully, but these errors were encountered: