Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style and layer metadata in Style#setState #3659

Closed
anandthakker opened this issue Nov 18, 2016 · 1 comment
Closed

Update style and layer metadata in Style#setState #3659

anandthakker opened this issue Nov 18, 2016 · 1 comment

Comments

@anandthakker
Copy link
Contributor

Currently, diffStyles just ignores changes in metadata properties. In light of smart setStyle, this may betray users' expectations, because after calling Map#setStyle with style JSON where metadata properties have changed, Map#getStyle() will currently yield a serialized style with the old metadata properties.

@anandthakker
Copy link
Contributor Author

Nope, I was wrong -- because of

this.stylesheet = nextState;
, we pick up the new stylesheet and its metadata just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant