-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "background" to "cover" or "fill" #4084
Comments
From @yhahn on November 20, 2014 4:29 Note: similar concept in Photoshop is called a Fill layer (http://www.dummies.com/how-to/content/how-to-use-fill-layers-in-photoshop-cs6.html) |
From @mourner on January 22, 2015 0:36 Is there an actual use case for many backgrounds or putting background in a different place? Cover doesn't sounds very intuitive to me... I'd rather throw an error if there are several backgrounds or if it's not in the back, and keep "background" name. |
From @edenh on January 22, 2015 0:39 Multiple background layers is useful. For example, a background layer with a transparent |
From @nickidlugash on January 22, 2015 0:53 I would be amenable to "Fill" layer if we weren't already using this layer name for something else...perhaps regardless of whether we implement polygon fills and lines in one layer (mapbox/mapbox-gl-style-spec#223), we can still rename the current "fill" layer to "polygon" layer and rename "background" to "fill"? Too confusing? |
From @edenh on January 22, 2015 0:57 I tend to think of background layers in terms of the css property: |
From @ljbade on January 22, 2015 7:9 What happens in the last background layer is transparent? I guess the glClearColor comes through? |
From @jfirebaugh on January 22, 2015 21:44 I was thinking along the same lines as @nickidlugash. This doesn't unlock any new capabilities, so let's pause on it until we see where #223 ends up. |
From @jfirebaugh on September 30, 2016 23:21 We should do this for v9, and then reintroduce That enables #3280 / mapbox/mapbox-gl-native#119. |
From @kkaefer on October 4, 2016 8:18 Why should they require a source? |
From @jfirebaugh on October 4, 2016 16:4 So that you can have two different "backgrounds":
|
Closing here; see #6584. |
From @edenh on November 19, 2014 22:23
Background is misleading because you can have many of them and they don't have to be "in the back". Let's rename to "cover".
Copied from original issue: mapbox/mapbox-gl-style-spec#219
The text was updated successfully, but these errors were encountered: