Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "background" to "cover" or "fill" #4084

Closed
lucaswoj opened this issue Feb 1, 2017 · 11 comments
Closed

Rename "background" to "cover" or "fill" #4084

lucaswoj opened this issue Feb 1, 2017 · 11 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @edenh on November 19, 2014 22:23

Background is misleading because you can have many of them and they don't have to be "in the back". Let's rename to "cover".

Copied from original issue: mapbox/mapbox-gl-style-spec#219

@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @yhahn on November 20, 2014 4:29

Note: similar concept in Photoshop is called a Fill layer (http://www.dummies.com/how-to/content/how-to-use-fill-layers-in-photoshop-cs6.html)

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @mourner on January 22, 2015 0:36

Is there an actual use case for many backgrounds or putting background in a different place? Cover doesn't sounds very intuitive to me... I'd rather throw an error if there are several backgrounds or if it's not in the back, and keep "background" name.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @edenh on January 22, 2015 0:39

Multiple background layers is useful. For example, a background layer with a transparent background-image with another solid color background layer underneath. Also, it is useful whenever you want to "tint" the entire map or a portion by applying a semi-transparent background layer higher up in the stack.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @nickidlugash on January 22, 2015 0:53

I would be amenable to "Fill" layer if we weren't already using this layer name for something else...perhaps regardless of whether we implement polygon fills and lines in one layer (mapbox/mapbox-gl-style-spec#223), we can still rename the current "fill" layer to "polygon" layer and rename "background" to "fill"? Too confusing?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @edenh on January 22, 2015 0:57

I tend to think of background layers in terms of the css property: background-size: "cover".

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @ljbade on January 22, 2015 7:9

What happens in the last background layer is transparent? I guess the glClearColor comes through?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @jfirebaugh on January 22, 2015 21:44

I was thinking along the same lines as @nickidlugash. This doesn't unlock any new capabilities, so let's pause on it until we see where #223 ends up.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @jfirebaugh on September 30, 2016 23:21

We should do this for v9, and then reintroduce background as a style-wide global property. Meanwhile cover layers should require a source, and only render on loaded tiles.

That enables #3280 / mapbox/mapbox-gl-native#119.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @kkaefer on October 4, 2016 8:18

Why should they require a source?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @jfirebaugh on October 4, 2016 16:4

So that you can have two different "backgrounds":

  • A base color or grid that shows up behind unloaded tiles
  • A "land" background that shows up on loaded tiles where there are no other features

@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@jfirebaugh
Copy link
Contributor

Closing here; see #6584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants