Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename text-size to text-font-size #4168

Closed
lucaswoj opened this issue Feb 1, 2017 · 1 comment
Closed

Rename text-size to text-font-size #4168

lucaswoj opened this issue Feb 1, 2017 · 1 comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @1ec5 on January 6, 2017 22:43

The text-size property should be renamed text-font-size. As part of #218, it would be shortened to font-size.

Contrary to the property’s current name, it does not specify the dimensions of the overall label the way text-max-width does. Instead, it specifies the font size in pixels. This inconsistency means a developer using the iOS or macOS SDK would be tempted to set the property to a CGSize or NSSize value instead of a number.

/cc @lucaswoj @jfirebaugh

Copied from original issue: mapbox/mapbox-gl-style-spec#650
@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@jfirebaugh jfirebaugh mentioned this issue May 1, 2018
Open
@jfirebaugh
Copy link
Contributor

Closing here; see #6584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfirebaugh @lucaswoj @1ec5