Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay with extrusion not possible #5457

Closed
VNuhaan opened this issue Oct 13, 2017 · 4 comments
Closed

overlay with extrusion not possible #5457

VNuhaan opened this issue Oct 13, 2017 · 4 comments

Comments

@VNuhaan
Copy link

VNuhaan commented Oct 13, 2017

I have a base layer and an overlay layer, both with buildings (fill-extrusions). Since version 40.0 I see extrusions (buildings) from the base layer pointing thru the overlay layer. It looks like that the drawing of extrusions ignores the layering order.

@lbud
Copy link
Contributor

lbud commented Oct 13, 2017

@VNuhaan can you please provide a screenshot or demo of what you're seeing? It's possible what you're describing could be intended behavior: v0.40.0 introduced a breaking rendering change in #5101, after which fill-extrusion layers share the same depth space in order to prevent physics-defying rendering like the left example below:
image

(This can result in some particular quirks as described in detail at #5288 (comment), wherein layer order can determine which extrusions are visible behind other translucent layers.)

@VNuhaan
Copy link
Author

VNuhaan commented Oct 16, 2017

high resolution overlay:
overlay
low resolution base layer:
base layer
combined:
base and overlay

Maybe it is an idee to combine extrusions of layers that are defined after each other.

@VNuhaan
Copy link
Author

VNuhaan commented Oct 26, 2017

Any news on this subject?

I think this behavior is indeed due to this #5101. But now I don't understand the layer order anymore. Fill-extrusions has there own ordering, beside all other types which use the layer ordering. The combination looks weird (picture in last screenshot above).

I was planning to add 3D trains in the near future. But without proper layering order it will end up nothing.

Please make it possible to ovelay fill-extrusions that can be smaller than fill-extrusions of layers below and draw the overlaying smaller fill-extrusions.

@lbud
Copy link
Contributor

lbud commented Oct 31, 2017

@VNuhaan I'm having a hard time seeing the issue in a static screenshot and diagnosing whether this behavior is incorrect. If you can provide a minimal interactive demo (jsfiddle or something similar) that would be helpful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants