Tilting compass as map tilted

[cs09g]

Motivation

When you rotate a map, compass on the navigation control rotates as much as the degree map rotated. but when you tilt the map, the compass doesn't interact for the pitch.

Also, when you click the compass, it makes the map degree to 0 as its default value but pitch would never be back to default even when you click the compass again.

I think when it interacts with both its bearing and pitch, will give better UX.
Implementation would look like(drag mouse on the MAP labeled element, and see compass below. and click the compass):
https://jsfiddle.net/cs09g/5an14p6r/

[mourner]

That's a cool idea! Want to make a PR with the change?

[cs09g]

Sure, one more discussion left about compass button clicking. One option is resetting bearing and pitch at once, the other is two-step reset-first click: reset bearing, second click(when bearing is 0): reset pitch. Which option would be better?

first option:

second option:

[cs09g]

@mourner Could you share your idea for the options?

[mourner]

I'm not sure, both seem good... @samanpwbb what do you think?

[andrewharvey]

I think one click to reset both is simpler.

[ryanhamley]

This is basically closed by #8226 The only thing not implemented in that PR is reseting the pitch when the compass button is clicked

[samanpwbb]

I checked Apple and Google maps for precedent and looks like neither use the compass to control pitch. The compass's sole purpose in both those apps is to communicate the cardinal directions and to allow user to reset direction. Pitching the compass makes directionality less clear.

Therefore, I am actually not sure a pitching compass control is a good idea. At the very least, this should be an optional feature.

If we do implement it, one click to reset would likely match user expectations most closely (double-click interactions like this are rare on the web).

[ryanhamley]

#8226 does implement pitching on the compass control but we could make the functionality optional in an additional PR that implements the on-click pitch reset.

[pakastin]

What would you suggest for the name of the pitching setting? controlPitch?

[pakastin]

Hmm.. but it already controls the pitch by default, so wouldn't make much sense 😂

Maybe visualizePitch?

[ryanhamley]

@samanpwbb You're saying that the compass icon shouldn't move at all by default right? That both pitch and bearing visualization should be optional.

[pakastin]

Therefore, I am actually not sure a rotating compass control is a good idea. At the very least, this should be an optional feature.

I think he meant:

Therefore, I am actually not sure a rotating pitching compass control is a good idea. At the very least, this should be an optional feature.