-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panning during pinch zoom gestures on Android Devices since version 1.4.0 #8889
Comments
Linking #8100, which might have introduced this regression. |
Thanks for the thorough report & demo pages @igu-tech ! So far I'm not really able to reproduce the issue with the map "moving away randomly" (on Android Chrome & Firefox on Samsung smartphone). I do notice some slight wandering as a I zoom in and out (because the center of my fingers/the map is gradually moving, and it's expected behavior that the map center will move to match the users' gesture, so that the user can pan and zoom the map at the same time), but that doesn't seem to match the behavior you're reporting. I do, however, notice my 2-finger touch occasionally being perceived as a 1-finger touch by the map which pans rather than zooms as a result (similar to #8375), so I wonder if that could have something to do with what you're seeing. Possibly in combination with another small bug we're aware of where the map jumps from one finger to another in certain transitions from 2 fingers to 1, I could imagine that jump being a possible culprit for what seems like a "random" move. In any case we'll investigate further and see what we can reproduce on other Android device(s). @igu-tech Do you notice this behavior when you have both fingers still firmly touching the screen? Or just as you're lifting your fingers? or both? cc @arindam1993 |
@igu-tech Great, thanks for the clarification and the video - this seems to support my hunch that the culprit is interaction between two-finger-zooming and single-finger dragging. I'll look into reproducing what you experience in the video and see if we can find a way to mitigate that. |
@ansis |
Thanks for testing! |
mapbox-gl-js version:
v.1.4.0 and newer
browser:
Android Chrome v. 78
Steps to Trigger Behavior
Link to Demonstration
BUG in v.1.4.0
https://storage.googleapis.com/my-test-env/mapbox.1.4.0.html
OK in v.1.3.2
https://storage.googleapis.com/my-test-env/mapbox.1.3.2.html
Expected Behavior
No move during zooming
Actual Behavior
Randomly moves the map while zooming with two fingers
The text was updated successfully, but these errors were encountered: